added django>=2.0 compat #551
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-as
commented
Jun 22, 2018
setup.py
Outdated
| 'Framework :: Django :: 1.10', | ||
| 'Framework :: Django :: 1.11', | ||
| 'Framework :: Django :: 2.0', | ||
| 'Framework :: Django :: 2.1', |
There was a problem hiding this comment.
@AGASS007 great!
are you planning to release a new version soon?
kingbuzzman
approved these changes
Jul 9, 2018
| TenantModel = get_tenant_model() | ||
| all_tenants = TenantModel.objects.all() | ||
| values = TenantModel.objects.values_list( |
There was a problem hiding this comment.
Instead of values_list() why not use only("schema_name", "domain_url")? That way you can still keep the (t.schema_name, t.domain_url,) for t in all_tenants]) because the way youre doing it now, the order can be reversed depending on the python version.
| ORIGINAL_BACKEND = getattr(settings, 'ORIGINAL_BACKEND', 'django.db.backends.postgresql_psycopg2') | ||
| # Django 1.9+ takes care to rename the default backend to 'django.db.backends.postgresql' | ||
| original_backend = django.db.utils.load_backend(ORIGINAL_BACKEND) | ||
| original_backend = django.db.utils.load_backend('django.db.backends.postgresql') |
There was a problem hiding this comment.
This can cause issues, i can see the need to not break this, i can come up with a couple scenarios on why you would want to override this.
|
Status? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.